Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

I don’t get these NIT-review at all. The best review would have been to push directly the change to their branch. That way the reviewe would have seen the fix, while gaining time and saving a back-and-forth.

When writing a review takes as long as changing the code, always prefer the latter.



I agree, but that removes the authors creativity and agency - which is why I opt to leave diff comments.


I would not amount choosing between a for-loop and list-comprehension as creativity.

Nor generally any work done on a CRUD app.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: